Conversation
| <minsize>80000000</minsize> | ||
| <maxsize>87500000</maxsize> | ||
| <maxsize>90000000</maxsize> | ||
| <files> | ||
| <file>${project.build.directory}/${project.build.finalName}-multi.jar</file> | ||
| </files> | ||
| </requireFilesSize> | ||
| <requireFilesSize> | ||
| <minsize>30000000</minsize> | ||
| <maxsize>50000000</maxsize> | ||
| <maxsize>51000000</maxsize> | ||
| <files> | ||
| <file>${project.build.directory}/${project.build.finalName}-linux-x64.jar</file> | ||
| <file>${project.build.directory}/${project.build.finalName}-win-x64.jar</file> |
There was a problem hiding this comment.
Updating the sizes, as the jar is just slightly above the limits, so it seems like only a slight increase.
[ERROR] Rule 0: org.apache.maven.enforcer.rules.files.RequireFilesSize failed with message: [ERROR] /tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT-multi.jar size (87528440) too large. Max. is 87500000/tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT-multi.jar
[ERROR] Rule 1: org.apache.maven.enforcer.rules.files.RequireFilesSize failed with message: [ERROR] /tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT-linux-x64.jar size (50579040) too large. Max. is 50000000/tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT-linux-x64.jar [ERROR]
[ERROR] /tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT.jar size (27659105) too large. Max. is 27500000/tmp/cirrus-ci-build/sonar-plugin/sonar-javascript-plugin/target/sonar-javascript-plugin-10.15.0-SNAPSHOT.jar
vdiez
left a comment
vdiez
left a comment
There was a problem hiding this comment.
Please sync versions with packages/jsts/src/rules/package.json
| onBackreferenceEnter: reference => { | ||
| const shouldSaveReference = isAmbiguousGroup(reference) | ||
| ? reference.resolved.filter(capturingGroup => capturingGroup.name).length > 0 | ||
| : reference.resolved.name !== null; | ||
| if (shouldSaveReference) { | ||
| backreferences.push(reference); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Updating this logic, as the typing changed in version 4.11.0 - eslint-community/regexpp@fb20f68
| function isAmbiguousGroup(reference: Backreference): reference is AmbiguousBackreference { | ||
| return reference.ambiguous; | ||
| } |
There was a problem hiding this comment.
Adding this as, just checking in the line below for: reference.ambigous ? "treat as ambiguous" : "treat as unambiguous" did not pass jest tests.... Looked a bit with @ericmorand-sonarsource , but failed to figure it out.
| const name = node.name!; | ||
| const used = backreferences.some(backreference => backreference.resolved === node); | ||
| const used = backreferences.some(backreference => | ||
| backreference.ambiguous |
There was a problem hiding this comment.
shouldn't we use same helper here?
zglicz
left a comment
zglicz
left a comment
There was a problem hiding this comment.
All of the ruling changes are accounted for.
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "ant-design:components/upload/__tests__/upload.test.js": [ | |||
| 37, | |||
There was a problem hiding this comment.
This stopped showing up due to an update in eslint-react-plugin in v7.36 - commit jsx-eslint/eslint-plugin-react#3807
| 28, | ||
| 38 | ||
| ], | ||
| "console:src/components/Help/Help.tsx": [ | ||
| 28, | ||
| 36 | ||
| ], | ||
| "console:src/components/PopupWrapper/PopupWrapper.tsx": [ | ||
| 47, | ||
| 56 |
There was a problem hiding this comment.
Same explanation for this file as above
| "desktop:app/src/ui/app-menu/app-menu-bar-button.tsx": [ | ||
| 190 | ||
| ], |
There was a problem hiding this comment.
This seems to be a false positive stemming from using React components and us not understanding it. This was first reported here - https://community.sonarsource.com/t/s6819-prefer-tag-over-role-is-misleading/107348/7 and we have a jira task to track these - https://github.com/SonarSource/SonarJS/issues/4647
I'm not sure why it just now starting showing up in the ruling, but I think it's fair.
| "moose:renderer/components/Downloads/Downloads.tsx": [ | ||
| 130 | ||
| ], | ||
| "moose:renderer/components/FilesList/FilesList.tsx": [ | ||
| 165 | ||
| ], |
There was a problem hiding this comment.
This is a true-positive, that wasn't triggering before
| 165 | ||
| ], |
| 19, | ||
| 26, |
There was a problem hiding this comment.
same explanation as above
|
2 participants
Use
ncu -i --format groupand for now, only bump the easy ones.